Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(22.04): add LXD backend to Spread #316

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

cjdcordeiro
Copy link
Collaborator

@cjdcordeiro cjdcordeiro commented Aug 21, 2024

Proposed changes

Used LXD as a Spread backend instead of docker. This is to cope with tests that need to perform privileged operations (like mount).

Related issues/PRs

#274 #222

Checklist

Additional Context

See a test here: https://github.com/cjdcordeiro/chisel-releases/actions/runs/10492345808/job/29063655589?pr=17 (note, the ARM64 tests fail cause this is my fork, under my account, which doesn't have access to arm64 runners)

Needs #317 for the CI to pass

@cjdcordeiro cjdcordeiro requested review from rebornplusplus and a team August 21, 2024 15:23
Copy link

Diff of dependencies:
None found.


@cjdcordeiro cjdcordeiro added the Blocked Waiting for something external label Aug 21, 2024
@cjdcordeiro cjdcordeiro changed the title test: add LXD backend to Spread test(22.04): add LXD backend to Spread Aug 22, 2024
@rebornplusplus
Copy link
Member

See a test here: https://github.com/cjdcordeiro/chisel-releases/actions/runs/10492345808/job/29063655589?pr=17

The test there seems to fail on ARM64. And logs are expired probably. Could you please re-trigger it?

spread.yaml Show resolved Hide resolved
spread.yaml Show resolved Hide resolved
@cjdcordeiro
Copy link
Collaborator Author

See a test here: https://github.com/cjdcordeiro/chisel-releases/actions/runs/10492345808/job/29063655589?pr=17

The test there seems to fail on ARM64. And logs are expired probably. Could you please re-trigger it?

Yes, cause that's my fork. arm runners aren't available to non-enterprise accounts.

Added a note in the description

@cjdcordeiro cjdcordeiro requested a review from linostar August 23, 2024 13:05
@cjdcordeiro cjdcordeiro self-assigned this Aug 23, 2024
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look alright to me. Holding approval until #317 is merged and the tests are passing properly here.

@cjdcordeiro cjdcordeiro added Priority Look at me first and removed Blocked Waiting for something external labels Aug 28, 2024
@cjdcordeiro cjdcordeiro requested review from rebornplusplus and a team August 28, 2024 11:05
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you. The diffs to the merged 24.04 changes are concise.


Diff with merged 24.04 changes
diff --git a/spread.yaml b/spread.yaml
index b2bb3b9..bdc21c6 100644
--- a/spread.yaml
+++ b/spread.yaml
@@ -38,9 +38,11 @@ backends:
       ADDRESS `lxc list --format=json $SPREAD_SYSTEM | jq -r '.[0].state.network.eth0.addresses[] | select(.family=="inet") | .address'`
     discard: lxc stop $SPREAD_SYSTEM || true
     systems:
-      - ubuntu-noble:
+      - ubuntu-jammy:
           password: ubuntu
-
+  
+  # The Docker backend is recommended for comprehensive multi-arch tests, but
+  # not ideal for tests that need to perform privileged operations (like "mount"). 
   docker:
     type: adhoc
     allocate: |
@@ -68,17 +70,17 @@ backends:
       ADDRESS `docker inspect $SPREAD_SYSTEM --format '{{.NetworkSettings.Networks.bridge.IPAddress}}'`
     discard: docker rm -f $SPREAD_SYSTEM
     systems:
-      - ubuntu-24.04-amd64:
+      - ubuntu-22.04-amd64:
           password: ubuntu
-      - ubuntu-24.04-arm64v8:
+      - ubuntu-22.04-arm64v8:
           password: ubuntu
-      - ubuntu-24.04-arm32v7:
+      - ubuntu-22.04-arm32v7:
           password: ubuntu
-      - ubuntu-24.04-ppc64le:
+      - ubuntu-22.04-ppc64le:
           password: ubuntu
-      - ubuntu-24.04-s390x:
+      - ubuntu-22.04-s390x:
           password: ubuntu
-      - ubuntu-24.04-riscv64:
+      - ubuntu-22.04-riscv64:
           password: ubuntu
 
 prepare: |

spread.yaml Outdated Show resolved Hide resolved
Co-authored-by: Rafid Bin Mostofa <[email protected]>
@cjdcordeiro cjdcordeiro merged commit a927005 into canonical:ubuntu-22.04 Aug 28, 2024
14 checks passed
cjdcordeiro added a commit to ozanmakes/chisel-releases that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Look at me first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants